[ts-command-line] Escape % characters in help text.#5281
Merged
iclanton merged 4 commits intomicrosoft:mainfrom Jul 23, 2025
Merged
[ts-command-line] Escape % characters in help text.#5281iclanton merged 4 commits intomicrosoft:mainfrom
% characters in help text.#5281iclanton merged 4 commits intomicrosoft:mainfrom
Conversation
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
dmichon-msft
approved these changes
Jul 23, 2025
octogonz
reviewed
Jul 23, 2025
| // Escape sprintf-style escape characters | ||
| // The primary special character in sprintf format strings is '%' | ||
| // which introduces format specifiers like %s, %d, %f, etc. | ||
| return input.replace(/%/g, '%%'); |
Collaborator
There was a problem hiding this comment.
After reviewing the source code for sprintf-js@1.0.3, this looks like a complete solution for ensuring the string will not be modified. 👍👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5278.
How it was tested
Added test cases.
Impacted documentation
None.